Skip to content

fix(installer): improve error message when port 4000 is already in use#1062

Merged
untitaker merged 1 commit into
EFForg:mainfrom
DevenDucommun:fix/installer-port-bind-error
Jun 9, 2026
Merged

fix(installer): improve error message when port 4000 is already in use#1062
untitaker merged 1 commit into
EFForg:mainfrom
DevenDucommun:fix/installer-port-bind-error

Conversation

@DevenDucommun

@DevenDucommun DevenDucommun commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Replace .unwrap() on TcpListener::bind with .with_context() so users see a clear message about the port conflict instead of a panic.

Fixes #906

Pull Request Checklist

  • The Rayhunter team has recently expressed interest in reviewing a PR for this.
    • If not, this PR may be closed due our limited resources and need to prioritize how we spend them.
  • Added or updated any documentation as needed to support the changes in this PR.
  • Code has been linted and run through cargo fmt.
  • If any new functionality has been added, unit tests were also added.
  • CONTRIBUTING.md has been read.
  • Your pull request is fewer than ~400 lines of code.

You must check one of:

  • No generative AI (including LLMs) tools were used to create this PR.
  • Generative AI was used to create this PR. I certify that I have read and understand the code, and that all comments and descriptions were authored by myself and are not the product of generative AI.

fix(installer): improve error message when port 4000 is already in use
9d67607 
Replace .unwrap() on TcpListener::bind with .with_context() so users
see a clear message about the port conflict instead of a panic.

Fixes EFForg#906
@DevenDucommun

DevenDucommun commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Fixing #906

error when port 4000 is in use. When Port 4000 is occupied the installer panics and throws an unwrap()backtrace. This fixes that with .with_context()

This contribution was developed with AI assistance. I have reviewed, understood, and tested the change.

@untitaker untitaker merged commit 2df3130 into EFForg:main Jun 9, 2026
24 checks passed
@untitaker

untitaker commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@untitaker untitaker untitaker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Installer fails with unclear message if port 4000 is already in use

2 participants

@DevenDucommun @untitaker